-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@/CivicSignalBlog: Add Web Tools authentication form configuration #1009
Conversation
Looks good @m453h (haven't checked the code yet). A few quick thoughts (totally open for discussion)
Of course, we may need a common place to put those common message that are the same across all forms, etc., but may be we don't need it now? If we do, then this can go into |
|
Hmmm 🤔 I like the idea of splitting the forms... let me move the components as per this suggestion and group the inputs as well, I think it would greatly improve the user experience |
@kilemensi, let me know if this arrangement for the login form makes more sense Screen.Recording.2024-12-02.at.16.05.26.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽 ... Definitely on the right track @m453h .
Not sure about "dynamic" fields. Don't we need to match names to what APIs expect e.g. email
field must be called email
, etc. If content editor renames it to emailAddress, will the form still work?
Besides that:
Lets arrange the sections as Publication, Forms and then Settings last.
Lets arrange forms as Title/Description, Fields, Actions (instead of Buttons as some actions could just be/look like links), and Messages (instead of Form Messages) last.
Yes we need to match the names, I had conflicting thoughts about dynamic fields (I opted to use them since they reduce repetitions in the code) and had kept a validator to ensure all the expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+
Co-authored-by: KEVIN KOECH <[email protected]>
…ica/ui into ft/civicsignalblog-auth_forms
@kilemensi to add a bit of context, I am using TextField in the Login, PasswordReset and Registration Forms instead of E-mail because, within the CMS, we expect the user to set what would appear as labels, error messages and hints on the font-end forms thus the user would always need to enter free text, using the E-mail field wouldn't work in this scenario. |
Cool, cool @m453h ... got you now. The forms here are just for collecting messages (error, hints, etc.) |
Description
This PR adds configuration globals for authentication forms used in the CivicSignal CMS.
Partially fixes this issue opened in the CivicSignal web-tools
Type of change
Please delete options that are not relevant.
Screenshots
Checklist: